feat: throw an Error if package.json has duplicate "repository" key (#1656)

lib/definitions/errors.js

@@ -29,6 +29,10 @@ Please make sure to add the \`repositoryUrl\` to the [semantic-release configura
       'docs/usage/configuration.md'
     )}).`,
   }),
+  EDUPLICATEREPOSITORYKEY: ({packageJsonPath}) => ({
+    message: 'Duplicate `"repository"` key in package.json.',
+    details: `Your package.json file at ${packageJsonPath} has more than one "repository" keys.`,
+  }),
   EGITNOPERMISSION: ({options: {repositoryUrl}, branch: {name}}) => ({
     message: 'Cannot push to the Git repository.',
     details: `**semantic-release** cannot push the version tag to the branch \`${name}\` on the remote Git repository with URL \`${repositoryUrl}\`.

lib/get-config.js

@@ -1,12 +1,15 @@
+const {readFile} = require('fs').promises;
 const {castArray, pickBy, isNil, isString, isPlainObject} = require('lodash');
-const readPkgUp = require('read-pkg-up');
+const findPkgUp = require('pkg-up');
 const {cosmiconfig} = require('cosmiconfig');
 const resolveFrom = require('resolve-from');
+const findDuplicatedPropertyKeys = require('find-duplicated-property-keys');
 const debug = require('debug')('semantic-release:config');
 const {repoUrl} = require('./git');
 const PLUGINS_DEFINITIONS = require('./definitions/plugins');
 const plugins = require('./plugins');
 const {validatePlugin, parseConfig} = require('./plugins/utils');
+const getError = require('./get-error');
 
 const CONFIG_NAME = 'release';
 const CONFIG_FILES = [
@@ -74,7 +77,7 @@ module.exports = async (context, cliOptions) => {
       {name: 'beta', prerelease: true},
       {name: 'alpha', prerelease: true},
     ],
-    repositoryUrl: (await pkgRepoUrl({normalize: false, cwd})) || (await repoUrl({cwd, env})),
+    repositoryUrl: (await pkgRepoUrl({cwd})) || (await repoUrl({cwd, env})),
     tagFormat: `v\${version}`,
     plugins: [
       '@semantic-release/commit-analyzer',
@@ -93,6 +96,18 @@ module.exports = async (context, cliOptions) => {
 };
 
 async function pkgRepoUrl(options) {
-  const {packageJson} = (await readPkgUp(options)) || {};
-  return packageJson && (isPlainObject(packageJson.repository) ? packageJson.repository.url : packageJson.repository);
+  const packageJsonPath = await findPkgUp(options);
+  if (!packageJsonPath) return;
+
+  const packageJsonString = await readFile(packageJsonPath, 'utf-8');
+  const result = findDuplicatedPropertyKeys(packageJsonString);
+
+  if (result.length > 0) {
+    throw getError('EDUPLICATEREPOSITORYKEY', {packageJsonPath});
+  }
+
+  const {repository} = require(packageJsonPath);
+  if (!repository) return;
+
+  return isPlainObject(repository) ? repository.url : repository;
 }